Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.2.0 #8

Closed
wants to merge 37 commits into from
Closed

Release/1.2.0 #8

wants to merge 37 commits into from

Conversation

maarten-ic
Copy link
Collaborator

@olivhoenen I think now is a good moment for a release before doing the major rename in #6. Please let me know what you think and if there's anything missing.

TODO before merging:

What's new in IMASPy 1.2.0

  • Open-source: IMASPy is now hosted on github and licensed under the LGPL-3.0
  • Add DBEntry.get_sample (requires imas_core > 5.4.0)
  • Improved validation of netCDF files
  • Improve compatibility with the UDA backend in imas_core

Bug fixes

  • Fix a bug when lazy loading multiple IDSs from the same HDF5 DBEntry (IMAS-5603)
  • Fix a bug when lazy loading a child quantity that was added in a newer DD version than stored on disk

maarten-ic and others added 30 commits July 9, 2024 13:55
In preparation for validating the NC data
Feature not yet implemented, see IMAS-5593
Merge in IMAS/imaspy from feature/refactor-nc2ids to develop

* commit 'd59fcabc29d5691004649bcf48016255010d7fa7':
  Add missing docstring
  Make the NC2IDS reader class-based
Ensure lazy contexts belonging to a different IDS are always closed.
See IMAS-5603 for more details.
… same HDF5 DBEntry

Merge in IMAS/imaspy from bugfix/IMAS-5603 to develop

* commit 'e5246464d588069af3f0f25e5a0e00d41d7fd4ef':
  Fix a bug with lazy loading multiple IDSs from the same HDF5 DBEntry
Also fix a couple of bugs when opening invalid netCDF files and raise a proper exception.
Merge in IMAS/imaspy from feature/IMAS-3885-IMASPy-get_sample to develop

* commit 'afb8c292c6527f03354ac35fa43dfaebd8fb4ef3':
  Update `get_sample` docstring to clarify that the interpolation mode has no effect on the `ids.time` vector.
  Disable MDSplus backend tests for get_sample
  Set `begin_timerange_action` as available since AL core 5.4
  Update NCDBEntryImpl for get_sample and raise NotImplementedError
  Update tests for DD 4.0.0
  Add docstrings for GetSliceParameters / GetSampleParameters
  Implement `DBEntry.get_sample` in IMASPy
Merge in IMAS/imaspy from feature/cli_validate_nc to develop

* commit 'fc2cbf20b3cf1c549761214109d3d89b4ee34091':
  Additional documentation for the `imaspy validate_nc` command line tool
  Add unit tests for `nc_validate.py`
  Close netCDF datasets when an exception is raised
  Fix incorrect exception when using mode="x" for netCDF files
  Add `validate_nc` command to imaspy CLI
maarten-ic and others added 7 commits December 12, 2024 15:43
Merge in IMAS/imaspy from fix/license-references to develop

* commit 'd80778fe6cdadf50255a50905a00ed9e2b458c8c':
  Replace references to LICENSE.md to LICENSE.txt
…4.0.0 (change in schemas layout)

Merge in IMAS/imaspy from identifiers-dd-schemas-layout to develop

* commit '74d2e3afe41a3fb907bc0a3729fcea29590aa4ca':
  Make prepare_data_dictionaries compatible with DD>4.0.0 (change in schemas layout)
Bug: IMASPy runs into an attribute error when lazy loading a child quantity that was added in a newer DD version than stored on disk.

Example:
1. Equilibrium IDS stored in DD 3.33.0
2. Lazy loading IDS with DD 4.0.0
3. Try to access `eq.time_slice[0].boundary.dr_dz_zero_point.r` resulted in an AttributeError

Root cause: IMASPy did not handle correctly that the `dr_dz_zero_point` was added between 3.33.0 and 4.0.0.

This commit fixes the bug.
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
@maarten-ic
Copy link
Collaborator Author

Plan is to have the rename PR finished soon, and create a 2.0 release afterwards.
Therefore we won't do the 1.2 release to avoid some overhead.

@maarten-ic maarten-ic closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants